Skip to content

Conversation

essjay05
Copy link
Contributor

Adds toolbar-basic-horizontal-example to components-examples for aria and implements it onto the dev-app aria-toolbar toolbar-demo.html page.

@essjay05 essjay05 requested a review from a team as a code owner October 17, 2025 22:41
@essjay05 essjay05 requested review from mmalerba and ok7sai and removed request for a team October 17, 2025 22:41
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Oct 17, 2025
@essjay05 essjay05 marked this pull request as draft October 17, 2025 22:57
@essjay05 essjay05 force-pushed the aria-demo-example-toolbar-basic-horizontal branch from 4f6e47d to 752a47f Compare October 17, 2025 23:27
@essjay05 essjay05 added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Oct 18, 2025
Copy link

github-actions bot commented Oct 18, 2025

Deployed dev-app for 98e7e75 to: https://ng-dev-previews-comp--pr-angular-components-32106-dev-ymzgw108.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@essjay05 essjay05 force-pushed the aria-demo-example-toolbar-basic-horizontal branch from a0322f3 to b299ff5 Compare October 20, 2025 15:45
@essjay05 essjay05 marked this pull request as ready for review October 20, 2025 15:46
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Adds toolbar-basic-horizontal-example to components-examples for
aria and implements it onto the dev-app aria-toolbar toolbar-demo.html
page.
Updates toolbar-demo.ts to consolidate the imports from
components-examples for toolbar.
@essjay05 essjay05 force-pushed the aria-demo-example-toolbar-basic-horizontal branch from 79a5b02 to 5f8ebab Compare October 20, 2025 18:46
Adds radiogroup UI into the toolbar basic horizontal example. Also
attempts to improve accessibility by adding LiveAnnouncer on button
activation.
Updates to fix naming convention lint error.
@essjay05 essjay05 force-pushed the aria-demo-example-toolbar-basic-horizontal branch from 5f8ebab to 98e7e75 Compare October 20, 2025 19:10
@wagnermaciel wagnermaciel added target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker labels Oct 20, 2025
@wagnermaciel wagnermaciel removed the request for review from mmalerba October 20, 2025 20:02
@wagnermaciel wagnermaciel merged commit ba9f79b into angular:main Oct 20, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit dev-app preview When applied, previews of the dev-app are deployed to Firebase target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants